Skip to content

[core] Force setgid permissions on folders #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Alxiice wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[core] Force setgid permissions on folders #3065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions meshroom/core/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import json
import logging
import os
import stat
import platform
import re
import shutil
Expand Down Expand Up @@ -569,6 +570,7 @@ def saveStatusFile(self):
statusFilepath = self.getStatusFile()
folder = os.path.dirname(statusFilepath)
os.makedirs(folder, exist_ok=True)
os.chmod(folder, os.stat(folder).st_mode | stat.S_ISGID) # Add setgid on folder

statusFilepathWriting = getWritingFilepath(statusFilepath)
with open(statusFilepathWriting, 'w') as jsonFile:
Expand Down Expand Up @@ -611,6 +613,7 @@ def saveStatistics(self):
statisticsFilepath = self.getStatisticsFile()
folder = os.path.dirname(statisticsFilepath)
os.makedirs(folder, exist_ok=True)
os.chmod(folder, os.stat(folder).st_mode | stat.S_ISGID) # Add setgid on folder
statisticsFilepathWriting = getWritingFilepath(statisticsFilepath)
with open(statisticsFilepathWriting, 'w') as jsonFile:
json.dump(data, jsonFile, indent=4)
Expand Down Expand Up @@ -1650,6 +1653,7 @@ def upgradeStatusFile(self):
statusFilepath = self.nodeStatusFile
folder = os.path.dirname(statusFilepath)
os.makedirs(folder, exist_ok=True)
os.chmod(folder, os.stat(folder).st_mode | stat.S_ISGID) # Add setgid on folder
statusFilepathWriting = getWritingFilepath(statusFilepath)
with open(statusFilepathWriting, 'w') as jsonFile:
json.dump(data, jsonFile, indent=4)
Expand Down
7 changes: 5 additions & 2 deletions meshroom/ui/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import logging
import os
import re
import stat
import json
from enum import Enum
from threading import Thread, Event, Lock
Expand Down Expand Up @@ -490,8 +491,10 @@ def loadGraph(self, filepath):
g = Graph("")
if filepath:
g.load(filepath)
if not os.path.exists(g.cacheDir):
os.mkdir(g.cacheDir)
cacheDir = g.cacheDir
if not os.path.exists(cacheDir):
os.mkdir(cacheDir)
os.chmod(cacheDir, os.stat(cacheDir).st_mode | stat.S_ISGID) # Add setgid on folder
self.setGraph(g)

@Slot(str)
Expand Down
Loading