Skip to content

[FeaturesViewer] Refactoring data/display from FeaturesViewer #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hdgnd wants to merge 2 commits into
base: develop
Choose a base branch
from

[doc] readme: add MFeatures and update FeaturesViewer

9cb02d5
Select commit
Loading
Failed to load commit list.
Draft

[FeaturesViewer] Refactoring data/display from FeaturesViewer #8

[doc] readme: add MFeatures and update FeaturesViewer
9cb02d5
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 21, 2026 in 25s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 245 in src/MFeatures.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "feature" is "class qtAliceVision::MFeature *". 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e_kkb8XHn6chqc8&open=AZ2u9e_kkb8XHn6chqc8&pullRequest=8

Check warning on line 360 in src/FeaturesViewer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant cast. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e5qkb8XHn6chqc5&open=AZ2u9e5qkb8XHn6chqc5&pullRequest=8

Check warning on line 356 in src/FeaturesViewer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant cast. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e5qkb8XHn6chqc4&open=AZ2u9e5qkb8XHn6chqc4&pullRequest=8

Check warning on line 241 in src/FeaturesViewer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant cast. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e5qkb8XHn6chqc3&open=AZ2u9e5qkb8XHn6chqc3&pullRequest=8

Check warning on line 95 in src/MFeatures.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This statement will not be executed conditionally. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9fABkb8XHn6chqdC&open=AZ2u9fABkb8XHn6chqdC&pullRequest=8

Check warning on line 91 in src/MFeatures.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this loop body so that it can be executed more than once. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9fABkb8XHn6chqdB&open=AZ2u9fABkb8XHn6chqdB&pullRequest=8

Check warning on line 203 in src/MFeatures.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e_kkb8XHn6chqc9&open=AZ2u9e_kkb8XHn6chqc9&pullRequest=8

Check warning on line 18 in src/MFeatures.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Class has 43 methods, which is greater than the 35 authorized. Split it into smaller classes. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9fABkb8XHn6chqdA&open=AZ2u9fABkb8XHn6chqdA&pullRequest=8

Check warning on line 10 in src/MDescFeatures.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reorder initializers to match the runtime order. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e_tkb8XHn6chqc-&open=AZ2u9e_tkb8XHn6chqc-&pullRequest=8

Check warning on line 361 in src/FeaturesViewer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant cast. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e5qkb8XHn6chqc6&open=AZ2u9e5qkb8XHn6chqc6&pullRequest=8

Check failure on line 184 in src/FeaturesViewer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e5qkb8XHn6chqc2&open=AZ2u9e5qkb8XHn6chqc2&pullRequest=8

Check warning on line 4 in src/MFeatures.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

non-portable path to file '"MSfMData.hpp"'; specified path differs in case from file name on disk 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9fABkb8XHn6chqc_&open=AZ2u9fABkb8XHn6chqc_&pullRequest=8

Check warning on line 41 in src/FeaturesViewer.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "enum" with "enum class". 

See more on https://sonarcloud.io/project/issues?id=alicevision_QtAliceVision&issues=AZ2u9e9Bkb8XHn6chqc7&open=AZ2u9e9Bkb8XHn6chqc7&pullRequest=8
View more details on SonarQubeCloud