fix(security): remove dangerous eval() usage in compare function#6
Open
BrandSnob wants to merge 1 commit into
Open
fix(security): remove dangerous eval() usage in compare function#6BrandSnob wants to merge 1 commit into
BrandSnob wants to merge 1 commit into
Conversation
Refactored the `compare` function to use a safe `switch` statement instead of `eval()` for date comparisons. This eliminates a potential Code Injection/Remote Code Execution (RCE) vulnerability where a manipulated `operator` argument could execute arbitrary code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
comparefunction to use a safeswitchstatement instead ofeval()for date comparisons. This eliminates a potential Code Injection/Remote Code Execution (RCE) vulnerability where a manipulatedoperatorargument could execute arbitrary code.I always support being lazy but also I always avoid using eval as much as possible
fixes #5