Skip to content

[TSK-73] 어드민 공지 응답, 리뷰 조회 응답 updatedAt, createdAt 추가 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boyekim merged 2 commits into from
Apr 16, 2026
Merged

[TSK-73] 어드민 공지 응답, 리뷰 조회 응답 updatedAt, createdAt 추가 #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02f5a99
refactor: 리뷰 조회 시 생성 일자 반환값 추가
boyekim Apr 12, 2026
0da0222
refactor: 어드민 공지 수정 및 조회 시 createdAt, updatedAt 칼럼 반환
boyekim Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/kr/allcll/backend/admin/notice/dto/AdminNoticeResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ public record AdminNoticeResponse(
String title,
String content,
OperationType operationType,
LocalDateTime createdAt
LocalDateTime createdAt,
LocalDateTime updatedAt
) {

public static AdminNoticeResponse from(Notice notice) {
Expand All @@ -18,7 +19,8 @@ public static AdminNoticeResponse from(Notice notice) {
notice.getTitle(),
notice.getContent(),
notice.getOperationType(),
notice.getCreatedAt()
notice.getCreatedAt(),
notice.getUpdatedAt()
);
}
}
2 changes: 2 additions & 0 deletions src/main/java/kr/allcll/backend/admin/notice/dto/UpdateNoticeResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ public record UpdateNoticeResponse(
String title,
String content,
OperationType operationType,
LocalDateTime createdAt,
LocalDateTime updatedAt
) {

Expand All @@ -18,6 +19,7 @@ public static UpdateNoticeResponse from(Notice notice) {
notice.getTitle(),
notice.getContent(),
notice.getOperationType(),
notice.getCreatedAt(),
notice.getUpdatedAt()
);
}
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/kr/allcll/backend/admin/review/AdminUserReviewApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import jakarta.servlet.http.HttpServletRequest;
import kr.allcll.backend.admin.AdminRequestValidator;
import kr.allcll.backend.admin.review.dto.AdminUserReviewResponses;
import kr.allcll.backend.admin.review.dto.AdminUserReviewsResponse;
import lombok.RequiredArgsConstructor;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -16,11 +16,11 @@ public class AdminUserReviewApi {
private final AdminUserReviewService adminUserReviewService;

@GetMapping("/api/admin/review")
public ResponseEntity<AdminUserReviewResponses> getReview(HttpServletRequest request) {
public ResponseEntity<AdminUserReviewsResponse> getReview(HttpServletRequest request) {
if (validator.isRateLimited(request) || validator.isUnauthorized(request)) {
return ResponseEntity.status(401).build();
}
AdminUserReviewResponses responses = adminUserReviewService.getReview();
AdminUserReviewsResponse responses = adminUserReviewService.getReview();
return ResponseEntity.ok(responses);
}
}
11 changes: 3 additions & 8 deletions src/main/java/kr/allcll/backend/admin/review/AdminUserReviewService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
package kr.allcll.backend.admin.review;

import java.util.List;
import kr.allcll.backend.admin.review.dto.AdminUserReviewResponse;
import kr.allcll.backend.admin.review.dto.AdminUserReviewResponses;
import kr.allcll.backend.admin.review.dto.AdminUserReviewsResponse;
import kr.allcll.backend.domain.review.UserReview;
import kr.allcll.backend.domain.review.UserReviewRepository;
import lombok.RequiredArgsConstructor;
Expand All @@ -16,12 +15,8 @@ public class AdminUserReviewService {

private final UserReviewRepository userReviewRepository;

public AdminUserReviewResponses getReview() {
public AdminUserReviewsResponse getReview() {
List<UserReview> reviews = userReviewRepository.findAll();
return new AdminUserReviewResponses(
reviews.stream()
.map(AdminUserReviewResponse::from)
.toList()
);
return AdminUserReviewsResponse.from(reviews);
}
}
7 changes: 5 additions & 2 deletions src/main/java/kr/allcll/backend/admin/review/dto/AdminUserReviewResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
package kr.allcll.backend.admin.review.dto;

import java.time.LocalDateTime;
import kr.allcll.backend.domain.operationPeriod.OperationType;
import kr.allcll.backend.domain.review.UserReview;

public record AdminUserReviewResponse(
String studentId,
Short rate,
String detail,
OperationType operationType
OperationType operationType,
LocalDateTime createdAt
Copy link
Copy Markdown
Member

@haeyoon1 haeyoon1 Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기에 updatedAt 안써도 되나요?

Copy link
Copy Markdown
Member

@goldm0ng goldm0ng Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 생각엔 요기는 유저가 리뷰를 수정하는 기능을 제공하지 않기 때문에 불필요한 응답 필드라고 생각함니다~!
createdAt만 있어도 충분할 것 같다고 판단되는데 어떻게 생각하시나용?

Copy link
Copy Markdown
Member Author

@boyekim boyekim Apr 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 맞아요~ 애초에 유저가 자기 리뷰를 볼 수 없고, 그래서 수정할 수도 없기 때문에 createdAt만 넣었습니다. 추후에 리뷰 확인 기능이 생기면 모를까 지금은 무의미할 것 같아서요.

) {

public static AdminUserReviewResponse from(UserReview userReview) {
return new AdminUserReviewResponse(
userReview.getStudentId(),
userReview.getRate(),
userReview.getDetail(),
userReview.getOperationType()
userReview.getOperationType(),
userReview.getCreatedAt()
);
}
}
9 changes: 0 additions & 9 deletions src/main/java/kr/allcll/backend/admin/review/dto/AdminUserReviewResponses.java
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions src/main/java/kr/allcll/backend/admin/review/dto/AdminUserReviewsResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package kr.allcll.backend.admin.review.dto;

import java.util.List;
import kr.allcll.backend.domain.review.UserReview;

public record AdminUserReviewsResponse(
List<AdminUserReviewResponse> reviews
) {

public static AdminUserReviewsResponse from(List<UserReview> reviews) {
return new AdminUserReviewsResponse(
reviews.stream()
.map(AdminUserReviewResponse::from)
.toList()
);
}
}
Loading