Mark parent step as failed if child step failed with soft check (fix #827)#854
Closed
sharovd wants to merge 3 commits into
Closed
Mark parent step as failed if child step failed with soft check (fix #827)#854sharovd wants to merge 3 commits into
sharovd wants to merge 3 commits into
Conversation
sharovd
force-pushed
the
fix-827-soft-check-nested-step-fail
branch
from
d0a51d7 to
557d037
Compare
Contributor
Author
|
@delatrie, hi! |
|
Could you please help merge this branch into master? This issue still occurs in allure-pytest version 2.14.3. |
用了大佬的方法，我纯搬运工，解决了我的难题，膜拜！ @sharovd 谢谢
|
|
I really need this functionality too! Maintainers, respond, please! |
The author has already submitted it. I wonder where you're from？ |
Contributor
|
Hello, everyone! Sorry, I didn't respond more quickly. Unfortunately, I have to close this PR. Please, see my comment in the associated issue for the motivation and the workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
sync_steps_statuses()method to synchronise the status for the parent step based on the status of the child steps. This method returnsTrueif at least one nested step has failed — allowing the parent step or the test itself to be marked as failedtest_pytest_fail_in_nested_step_with_soft_check()to validate the described test scenarioChecklist