feat(cli): expose IsanAgent ACP mode via altai acp - #232
Merged
Conversation
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully adds Agent Client Protocol (ACP) support to the ALTAI CLI, enabling it to function as an ACP JSON-RPC server over stdio for editors like Zed. The implementation is well-structured and follows established patterns.
Key additions:
- New
acp_host_config()function that properly configuresacp_mode = true altai acpcommand with full argument parsing and dry-run support- Comprehensive unit tests for both host adapter and CLI contract
- Clear documentation updates distinguishing ACP mode from the existing
altai serve --stdioprotocol
The implementation demonstrates good engineering practices with consistent error handling, proper integration with existing compaction/theme/permission infrastructure, and thorough test coverage. The code is ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Bump IsanAgent to the ACP agent tip and add a stdio ACP host command so editors like Zed can drive ALTAI without using the ALTAI serve protocol. Co-authored-by: Cursor <cursoragent@cursor.com>
efecnc
force-pushed
the
feat/cli-acp-support
branch
from
July 31, 2026 07:26
5c03fbe to
9408cab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
7018685(isanagent#102) for Agent Client Protocol agent support.altai acpto start IsanAgent as an ACP JSON-RPC server on stdio (HostConfig.acp_mode), distinct fromaltai serve --stdio(ALTAI agent-host protocol).host_adapter::acp_host_config, clap dry-run preview, and unit/contract tests.Test plan
cargo test -p altai-cli acpcargo check -p altai --libaltai-cli acp --dry-run .shows"kind": "acp"and"acp_mode": truealtai-cli acp --workspace <path>and verifyinitialize/session/new/session/promptMade with Cursor