Skip to content

feat: wire clarification responses in VS Code (TASK-011) - #13

Merged
efecnc merged 2 commits into
mainfrom
feat/task-011-vscode-clarification
Aug 5, 2026
Merged

feat: wire clarification responses in VS Code (TASK-011)#13
efecnc merged 2 commits into
mainfrom
feat/task-011-vscode-clarification

Conversation

@efecnc

@efecnc efecnc commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Depends on altaidevorg/altai-app#361.

Summary

  • route clarification reply/dismiss and approval approve/deny through the native clarification/respond contract
  • enable the shared clarification and approval UI only when that native capability is advertised

Test plan

  • npm run verify

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implements clarification response routing for VS Code by wiring the native clarification/respond contract. The implementation correctly advertises the capability based on native availability and includes comprehensive test coverage.

One critical issue requires attention: the ticketId parameter is not being forwarded to the RPC call, which may cause backend failures if this parameter is expected.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Comment on lines +197 to +201
await transport.request("clarification/respond", {
chat_id: input.chatId,
action: input.action,
...(input.action === "reply" ? { text: input.text ?? "" } : {}),
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Logic Error: The ticketId parameter from the input is not being forwarded to the RPC call. The test at line 172 in the test file passes ticketId: "ticket_1", but this parameter is ignored in the implementation. If the backend expects this parameter, this will cause incorrect behavior or failures.

Suggested change
await transport.request("clarification/respond", {
chat_id: input.chatId,
action: input.action,
...(input.action === "reply" ? { text: input.text ?? "" } : {}),
});
await transport.request("clarification/respond", {
chat_id: input.chatId,
ticket_id: input.ticketId,
action: input.action,
...(input.action === "reply" ? { text: input.text ?? "" } : {}),
});

@efecnc
efecnc merged commit e80dfd0 into main Aug 5, 2026
1 check passed
@efecnc
efecnc deleted the feat/task-011-vscode-clarification branch August 5, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant