feat: wire clarification responses in VS Code (TASK-011) - #13
Conversation
There was a problem hiding this comment.
This PR implements clarification response routing for VS Code by wiring the native clarification/respond contract. The implementation correctly advertises the capability based on native availability and includes comprehensive test coverage.
One critical issue requires attention: the ticketId parameter is not being forwarded to the RPC call, which may cause backend failures if this parameter is expected.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| await transport.request("clarification/respond", { | ||
| chat_id: input.chatId, | ||
| action: input.action, | ||
| ...(input.action === "reply" ? { text: input.text ?? "" } : {}), | ||
| }); |
There was a problem hiding this comment.
🛑 Logic Error: The ticketId parameter from the input is not being forwarded to the RPC call. The test at line 172 in the test file passes ticketId: "ticket_1", but this parameter is ignored in the implementation. If the backend expects this parameter, this will cause incorrect behavior or failures.
| await transport.request("clarification/respond", { | |
| chat_id: input.chatId, | |
| action: input.action, | |
| ...(input.action === "reply" ? { text: input.text ?? "" } : {}), | |
| }); | |
| await transport.request("clarification/respond", { | |
| chat_id: input.chatId, | |
| ticket_id: input.ticketId, | |
| action: input.action, | |
| ...(input.action === "reply" ? { text: input.text ?? "" } : {}), | |
| }); |
Depends on altaidevorg/altai-app#361.
Summary
clarification/respondcontractTest plan