Revert "feat(host): oneshot, theme, approvals, attachments, compaction" - #100
Conversation
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR reverts PR #99, removing oneshot, theme, approvals, attachments, and compaction features. The revert is generally clean and complete, with one critical issue identified:
Critical Issue:
- The Plan permission mode mapping was changed from
("ask", "deny")to("deny", "deny")in this revert, but the diff shows the original code in PR #99 changed it from("deny", "deny")to("ask", "deny"). This revert restores the original("deny", "deny")behavior, which appears correct for a revert.
Verified:
- Struct field removals are consistent across the codebase
TerminalChannelConfigcorrectly reflects the reverted state- No missing imports or compilation issues
- Explicit field initialization correctly replaces
..Default::default()
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| // Match desktop: plan keeps shell at ask (read-only inspection with | ||
| // approval for destructive commands) while denying file edits. | ||
| HostPermissionMode::Plan => ("ask", "deny"), | ||
| HostPermissionMode::Plan => ("deny", "deny"), |
There was a problem hiding this comment.
🛑 Logic Error: This line changes Plan mode from ("ask", "deny") to ("deny", "deny"), which is not a pure revert. The reverted PR #99 changed this from ("deny", "deny") to ("ask", "deny"), but the pre-PR-99 code had ("deny", "deny"). This revert should restore the exact pre-PR-99 behavior unless there's a documented reason for the change.
1 participant
Reverts #99