Skip to content

feat: report clarification dismiss ownership - #104

Merged
monatis merged 1 commit into
mainfrom
feat/clarification-dismiss-ownership
Aug 5, 2026
Merged

feat: report clarification dismiss ownership#104
monatis merged 1 commit into
mainfrom
feat/clarification-dismiss-ownership

Conversation

@efecnc

@efecnc efecnc commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a backwards-compatible ClarificationHub API that atomically claims a pending dismissal
  • preserve the existing cancellation method
  • cover duplicate dismissal rejection

Test plan

  • cargo test clarification::tests

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation correctly adds atomic clarification dismissal ownership while maintaining backward compatibility. The refactoring of cancel_wait to delegate to cancel_wait_if_pending preserves existing behavior, and the new method properly uses DashMap's remove operation to atomically claim pending dismissals. Test coverage appropriately validates the single-claim behavior.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@monatis
monatis merged commit a5d799b into main Aug 5, 2026
2 checks passed
@monatis
monatis deleted the feat/clarification-dismiss-ownership branch August 5, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants