Fix Helm Chart so extraArgs and extraEnv render correctly#151
Fix Helm Chart so extraArgs and extraEnv render correctly#151mattparkes wants to merge 1 commit intoamazon-archives:masterfrom
Conversation
|
I have not incremented the Let me know if you think it is preferred/appropriate to do so and I'll increment it to |
|
A colleague of mine just pointed out that technically the existing template did work if you used: So rather than changing the template, I could have just changed the default
renders as: So a change is still needed to fix that. I guess this totally a stylistic choice, so if anyone has a strong preference, I'm happy to adjust this PR to suit. |
|
So sounds like we can actually just change the And the second change lgtm. Would you mind just going back to using the |
Issue: #150
Description of changes:
Fix Helm Chart so extraArgs and extraEnv render correctly.
Testing:
Can test/validate by using a values file (
test.yaml) whose contents are exactly as per the defaultvalues.yaml, but with the addition of testing--key=valueextraArgs items render properly:helm template ./aws-service-operator/ -f test.yamlBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.