Skip to content

WIP: Add support for Array-Type in JSON#42

Open
muditsin wants to merge 1 commit into
amplab:masterfrom
muditsin:Array-JSON
Open

WIP: Add support for Array-Type in JSON#42
muditsin wants to merge 1 commit into
amplab:masterfrom
muditsin:Array-JSON

Conversation

@muditsin

Copy link
Copy Markdown
Contributor

Fixes: #35

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@muditsin

Copy link
Copy Markdown
Contributor Author

@anuragkh PR is currently WIP, but wanted to check if the approach was alright

@anuragkh

Copy link
Copy Markdown
Collaborator

Hi @muditsin, thanks for contributing!

The approach looks about right to me, although there is some code duplication (e.g., parsing the values in the array is the same as parsing individual values). Perhaps making them modular might help reduce code redundancy.

@muditsin

muditsin commented Feb 2, 2019

Copy link
Copy Markdown
Contributor Author

@anuragkh Updated to reduce duplication. Thanks!

@anuragkh

anuragkh commented Feb 2, 2019

Copy link
Copy Markdown
Collaborator

Jenkins, test this please.

1 similar comment
@anuragkh

anuragkh commented Feb 2, 2019

Copy link
Copy Markdown
Collaborator

Jenkins, test this please.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Succinct-PRB/3/

Build result: FAILURE

[...truncated 216 lines...][INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project succinct-serde: Compilation failure[ERROR] /home/jenkins/workspace/Succinct-PRB/serde/src/main/java/edu/berkeley/cs/succinct/object/deserializer/JsonDeserializer.java:[119,54] error: ';' expected[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :succinct-serde[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/assembly/pom.xml to amplab/succinct-assembly/0.1.8/succinct-assembly-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/pom.xml to amplab/succinct/0.1.8/succinct-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/spark/pom.xml to amplab/succinct-spark/0.1.8/succinct-spark-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/serde/pom.xml to amplab/succinct-serde/0.1.8/succinct-serde-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/core/pom.xml to amplab/succinct-core/0.1.8/succinct-core-0.1.8.pom[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/core/target/succinct-core-0.1.8.jar to amplab/succinct-core/0.1.8/succinct-core-0.1.8.jar[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/core/target/succinct-core-0.1.8-tests.jar to amplab/succinct-core/0.1.8/succinct-core-0.1.8-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Succinct-PRB/core/target/succinct-core-0.1.8-jar-with-dependencies.jar to amplab/succinct-core/0.1.8/succinct-core-0.1.8-jar-with-dependencies.jarSending e-mails to: anuragk@berkeley.educhannel stopped
Test FAILed.

@muditsin

muditsin commented Feb 3, 2019

Copy link
Copy Markdown
Contributor Author

Jenkins, test this please.

2 similar comments
@muditsin

muditsin commented Feb 6, 2019

Copy link
Copy Markdown
Contributor Author

Jenkins, test this please.

@anuragkh

anuragkh commented Feb 6, 2019

Copy link
Copy Markdown
Collaborator

Jenkins, test this please.

@anuragkh

anuragkh commented Feb 6, 2019

Copy link
Copy Markdown
Collaborator

@muditsin, Jenkins is only triggered by repo admins and whitelisted committers atm. I'll add you to whitelist.

@anuragkh

anuragkh commented Feb 6, 2019

Copy link
Copy Markdown
Collaborator

Jenkins, add to whitelist.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Succinct-PRB/4/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Succinct-PRB/5/
Test PASSed.

@anuragkh

anuragkh commented Feb 6, 2019

Copy link
Copy Markdown
Collaborator

@muditsin Can you please add tests for the new data types you have added?

@muditsin

muditsin commented Feb 6, 2019

Copy link
Copy Markdown
Contributor Author

@anuragkh Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants