Fix overriding stricter configured TLS minimum version - #406
Open
markwinds wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SSL configuration commands are applied before the default minimum TLS
version is set.
When users configure:
the configured value is subsequently overwritten by:
As a result, TLS 1.2 becomes enabled even though the user requested
TLS 1.3 as the minimum version.
Solution
Read the minimum protocol version after applying SSL configuration
commands. Set TLS 1.2 only when no minimum version was configured or
when the configured version is lower than TLS 1.2.
This preserves the existing secure default while respecting stricter
user configurations such as TLS 1.3.
Compatibility
The getter is used only for OpenSSL 1.1.1 and later under the existing
version guard. Older OpenSSL versions retain the existing behavior.