Fix EPOLLRDHUP/POLLRDHUP mismatch on Linux SPARC/SPARC64 - #407
Open
passgat wants to merge 1 commit into
Open
Conversation
Fix a build failure reported by Buildroot autobuild for the bootlin-sparc64-glibc configuration: EpollPoller.cc:41:26: error: static assertion failed: EPOLLRDHUP != POLLRDHUP On SPARC/SPARC64, EPOLLRDHUP (0x2000) and POLLRDHUP (0x0800) are different bits, breaking the assumption elsewhere in this file that epoll and poll flags are interchangeable. Introduce a combined RDHUP value for this architecture and translate it before epoll_ctl() and after epoll_wait(), since revents_ is later tested against POLLRDHUP in Channel::handleEvent() — otherwise half-close detection would silently break at runtime. This patch is inspired by the equivalent fix in lighttpd: https://redmine.lighttpd.net/issues/3251 Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a build failure reported by Buildroot autobuild for the bootlin-sparc64-glibc configuration:
EpollPoller.cc:41:26: error: static assertion failed:
EPOLLRDHUP != POLLRDHUP
On SPARC/SPARC64, EPOLLRDHUP (0x2000) and POLLRDHUP (0x0800) are different bits, breaking the assumption elsewhere in this file that epoll and poll flags are interchangeable.
Introduce a combined RDHUP value for this architecture and translate it before epoll_ctl() and after epoll_wait(), since revents_ is later tested against POLLRDHUP in Channel::handleEvent() — otherwise half-close detection would silently break at runtime.
This patch is inspired by the equivalent fix in lighttpd: https://redmine.lighttpd.net/issues/3251