hw-matlab.yml: pass --skip-boot to adi-lg-matlab run#206
Merged
Conversation
The lab's coordinator places are tagged with boot-strategy=BootZynq7000JTAGRecovery, whose template does not yet expose the consumer-supplied kernel/uboot/initramfs/bitstream paths a real transition needs. Without --skip-boot, the matrix shard fails at get_driver(boot_strategy) / strategy.transition() before MATLAB ever starts. With --skip-boot the shard still acquires the place and resolves the booted board's NetworkService URI into IIO_URI; the toolbox's test/HardwareTests.m CheckDevice gracefully reports 'No device found' when the board is not reachable. The full launcher pipeline (acquire, resolve, MATLAB launch, JUnit, release) is exercised. Drop the flag once the lab template carries the recovery inputs. Needs tfcollins/labgrid-plugins#33 (now merged); @v2 ref includes the --skip-boot flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the HW matrix shards actually reach MATLAB. Today they fail at strategy instantiation because the lab's coordinator places are tagged `boot-strategy=BootZynq7000JTAGRecovery`, whose env-yaml template doesn't yet expose the consumer-supplied kernel/uboot/initramfs/bitstream paths needed for a real `strategy.transition()`.
`--skip-boot` (added in tfcollins/labgrid-plugins#33, merged) makes the launcher acquire the place and resolve the `NetworkService` URI without trying to transition the strategy. The toolbox's `test/HardwareTests.m` already honours `IIO_URI` and `CheckDevice` gracefully `assumeFail`s when libIIO can't reach the address — so the full pipeline (acquire → resolve URI → MATLAB launch → JUnit → release) is exercised, and when the lab eventually supplies the recovery inputs the boards will report real test outcomes.
Drop the flag once the lab template carries the recovery inputs (or the lab retags places with a boot-strategy that has plug-and-play inputs, like `BootFPGASoC` for SD-Mux setups).