Dev/adhv4711#3181
Open
raezt wants to merge 2 commits into
Open
Conversation
Add enum adhv4710_type { ID_ADHV4710, ID_ADHV4711 } and a
struct adhv4710_chip_info table indexed by that enum, holding the
per-variant expected version_product value.
- Add an id field to adhv4710_init_param and adhv4710_dev; init now
stores the selected variant and validates CTRL_REG_26 against
chip_info[dev->id].version_product.
Signed-off-by: Radu Etz <radu.etz@analog.com>
raezt
marked this pull request as ready for review
July 1, 2026 16:01
raezt
requested review from
CiprianRegus,
RaduSabau1,
amiclaus,
buha,
cristina-suteu,
danmois,
dbogdan,
ralucabozdog,
ranechita,
rbolboac,
rbudai98 and
stefpopa
as code owners
July 1, 2026 16:01
- Add ADHV4710_DEV_ID macro (default ID_ADHV4710) in common_data.h and set adhv4710_ip.id from it in main.c. - Add README.rst documenting both boards, the variant-selection mechanism and the Maxim build commands. ID_ADHV4710 is enum value 0, so zero-initialized init params default to the ADHV4710 variant and existing callers are unaffected. Signed-off-by: Radu Etz <radu.etz@analog.com>
buha
reviewed
Jul 6, 2026
| .. code-block:: bash | ||
|
|
||
| # to delete current build | ||
| make reset |
Contributor
There was a problem hiding this comment.
can you please document the new build system rather than the old one ? all maxim projects are currently transitioning, there is a big PR currently open #3184 and if you add a README.md, new build system should be documented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add ADHV4711 variant support via chip-info table:
The ADHV4710 and ADHV4711 are variants of the same device, sharing the
register map and control logic and differing only in the product-version
(chip-id) register CTRL_REG_26 (0x46 vs 0x47). Support both from the
single driver instead of duplicating it.
PR Type
PR Checklist