Fix Python test failures for Windows compatibility

[anchapin]

Summary

Fixes #484

This PR resolves Python test failures on Windows by fixing temp file handling.

Problem

On Windows, NamedTemporaryFile with delete=False followed by os.unlink() causes PermissionError because Windows cannot delete files that are still open.

Solution

Replace NamedTemporaryFile with TemporaryDirectory context manager which:

• Creates a unique temp directory
• Handles cleanup automatically when context exits
• Works on both Windows and Unix systems

Changes Made

• test_load_json_config: Use TemporaryDirectory instead of NamedTemporaryFile
• test_load_yaml_config: Use TemporaryDirectory instead of NamedTemporaryFile
• test_reload_config: Use TemporaryDirectory instead of NamedTemporaryFile
• test_config_with_env_overrides: Use TemporaryDirectory instead of NamedTemporaryFile

Test Results

All 30 tests pass:
```
============================== 30 passed in 0.24s ==============================
```

Test Plan

• Run pytest tests/test_daemon_config.py -v - all tests pass
• Pre-commit hooks pass
• CI workflow passes

Summary by Sourcery

Update configuration tests to use directory-based temporary files for better cross-platform compatibility.

Bug Fixes:

• Resolve Windows-specific test failures caused by deleting open temporary files.

Tests:

• Refactor configuration loading and reload tests to create config files within TemporaryDirectory contexts instead of NamedTemporaryFile.

[sourcery-ai]

Reviewer's Guide

Refactors daemon configuration tests to use TemporaryDirectory-based config files instead of NamedTemporaryFile, improving Windows compatibility and simplifying cleanup while preserving existing test behavior and assertions.

File-Level Changes

Change	Details	Files
Use TemporaryDirectory-based config files instead of NamedTemporaryFile for JSON/YAML loading tests to avoid Windows file handle issues.	Wrap JSON config creation in TemporaryDirectory and write to a regular file path Remove manual file flushing and os.unlink cleanup for the JSON config test Ensure ConfigLoader uses the new file path and existing assertions remain unchanged	agent/tests/test_daemon_config.py
Update YAML config loading test to use TemporaryDirectory and explicit file path while keeping behavior and assertions identical.	Create a temporary directory and write YAML config to a named file in that directory Remove explicit flush and manual deletion logic Load configuration via ConfigLoader using the new path and keep all assertions the same	agent/tests/test_daemon_config.py
Adjust config reload and env override tests to use TemporaryDirectory-backed config files, relying on context manager cleanup instead of manual unlinking.	Create JSON config files inside TemporaryDirectory for reload and env override tests Remove try/finally blocks with os.unlink cleanup since TemporaryDirectory handles cleanup Reuse existing ConfigManager and env override logic unchanged to validate behavior	agent/tests/test_daemon_config.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#484	Handle Windows incompatibility of Unix domain sockets in vsock_client tests (e.g., skip or provide alternative when socket.AF_UNIX is unavailable) so that TestVsockClient::test_connect_success passes on Windows.	❌	The PR only modifies tests in tests/test_daemon_config.py to change temporary file handling. It does not touch vsock_client or TestVsockClient, nor does it add any Windows-specific skip or alternative for socket.AF_UNIX.
#484	Ensure tests that depend on optional LLM clients (openai, anthropic) either have their dependencies declared/installed or are skipped/mocked when the packages are unavailable, so the six TestBuildFallbackClient tests pass in CI.	❌	The PR does not modify dependency configuration (e.g., pyproject.toml) or the LLM fallback tests. There are no changes related to openai or anthropic imports, skips, or mocks.
#484	Fix remaining Windows-specific test failures by resolving temp file PermissionError issues in daemon config tests and addressing the timing/race condition in TestAuditLogger::test_retention so all affected tests pass on Windows.	❌	The PR updates tests in tests/test_daemon_config.py to use tempfile.TemporaryDirectory instead of NamedTemporaryFile, which likely fixes the PermissionError on Windows for those three tests. However, it does not modify TestAuditLogger::test_retention or any audit logger code, so the timing/race condition failure remains. Since the objective includes both the temp file fixes and the race-condition test, the objective is only partially met and thus not fully addressed.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Since these tests are all using temporary filesystem locations now, consider switching to pytest’s built-in tmp_path/tmp_path_factory fixtures instead of tempfile.TemporaryDirectory to simplify setup and avoid manual os.path.join usage.
• The repeated pattern of creating a temp config file (JSON/YAML) and then loading it could be factored into a small helper to reduce duplication and make it easier to adjust temp-file behavior in one place in the future.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Since these tests are all using temporary filesystem locations now, consider switching to pytest’s built-in `tmp_path`/`tmp_path_factory` fixtures instead of `tempfile.TemporaryDirectory` to simplify setup and avoid manual `os.path.join` usage.
- The repeated pattern of creating a temp config file (JSON/YAML) and then loading it could be factored into a small helper to reduce duplication and make it easier to adjust temp-file behavior in one place in the future.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}