feat: use the app version for tag in admission controller#552
Open
bradleyjones wants to merge 4 commits into
Open
feat: use the app version for tag in admission controller#552bradleyjones wants to merge 4 commits into
bradleyjones wants to merge 4 commits into
Conversation
Signed-off-by: bradleyjones <jones.bradley@me.com>
Signed-off-by: Hung Nguyen <me@hnguy.com>
Signed-off-by: Hung Nguyen <me@hnguy.com>
Signed-off-by: Hung Nguyen <me@hnguy.com>
hn23
force-pushed
the
simplify-image-tag
branch
from
e866c17 to
7362069
Compare
Contributor
|
Hey @bradleyjones I made some updates, taking your idea but doing it differently as to not break current customers. Take a look and let me know what you think. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bradleyjones jones.bradley@me.com