-
Notifications
You must be signed in to change notification settings - Fork 824
feat: add go symbol matching qualifier for better go vuln matching #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spiffcs
wants to merge
22
commits into
main
Choose a base branch
from
go-symbol-matching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
34f4918
feat: add go symbol matching qualifier for better go vuln matching
spiffcs b621b65
fix: cleanup
spiffcs 6d90173
ci: ci
spiffcs da7616e
fix: add warning when no symbols generated
spiffcs 1471965
unit: fix unit tests for default config
spiffcs ead01ff
wip: test pattern for go binary matching
willmurphyscode 12ad09a
feat: Govuln --> GHSA merge wip
spiffcs 339856c
fix: case-insensitive GHSA row matching
spiffcs 0f76a8b
test: remove go binary test data
spiffcs 46e8d06
pr: review and doc feedback
spiffcs 329d670
Merge remote-tracking branch 'origin/main' into go-symbol-matching
spiffcs 1968995
fix: static-analysis
spiffcs 5f71f70
test: new test cases
spiffcs 270ed54
fix: comments
spiffcs 030845a
add additional tests
wagoodman e98a1a5
test: toolchain pseudo-module coverage
spiffcs fdfaa9d
lint: format json for easy diff view
spiffcs 2ac4c35
add test case for mix of path only and path+symbol qualifiers
willmurphyscode 4a51a2c
fix: separate merge/write concerns
spiffcs e728b7c
test: fix tests for new merge
spiffcs 7d9e2ec
tests: add new coverage for cited vuln issues
spiffcs ea62361
fix: backfill missing fix dates go records
spiffcs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the grype report what of the symbol data should we end up including? Just what the intersection was that caused the match or the full table for the package?