fix(go-module-cataloger): use correct error variable in package load #4983
Open
idhyt wants to merge 1 commit into
Open
fix(go-module-cataloger): use correct error variable in package load #4983idhyt wants to merge 1 commit into
idhyt wants to merge 1 commit into
Conversation
…loop In the loop over `rootPkgs`, the error appended to `unknownErr` was incorrectly using the outer `err` (from `packages.Load`) instead of the individual package error `e`. This could cause: - nil or stale error values to be recorded when package-specific errors existed. - Loss of detailed per-package error information in the final error report. Changed `unknown.Append(..., err)` to `unknown.Append(..., e)` to properly capture each package's load error. Signed-off-by: idhyt <idhyt3r@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the loop over
rootPkgs, the error appended tounknownErrwas incorrectly using the outererr(frompackages.Load) instead of the individual package errore. This could cause:Changed
unknown.Append(..., err)tounknown.Append(..., e)to properly capture each package's load error.Type of change
Checklist