fix undesirable upscaling small images #45#79
Open
isaacchansky wants to merge 2 commits intoandismith:masterfrom
Open
fix undesirable upscaling small images #45#79isaacchansky wants to merge 2 commits intoandismith:masterfrom
isaacchansky wants to merge 2 commits intoandismith:masterfrom
Conversation
…option of for test which expect an upscaled result image.
|
Hey, @andismith! We are struggling with issue #45 and it would be nice to have this fix in upstream. Is there any problems with this PR? |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test and a fix for the issue of small images getting upscaled ( #45 ).
For example, I run a default image resizing job and want three directories (small, med, large).
I also want to have image paths for an icon at:
small/icon.png,med/icon.png,large/icon.png. But, if the original icon size is 48x48px, I want it to remain be no bigger than the original, even in the large directory.The only difference in any API's now should be that to upscale small images, you must opt-in via
upscale:true. Not sure if this might be a breaking change because of this.