[codex] Improve remaining Scorecard drivers#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fast-checkproperty coverage for CSRF parsing, endpoint building, and timeout env parsingpublish_resultsworks againWhy
The merged workflow-hardening PR improved the Scorecard configuration surface, but the live Scorecard workflow exposed one follow-up issue:
ossf/scorecard-actionhad been pinned to an annotated tag object SHA instead of the underlying commit SHA accepted by Scorecard workflow verification. This PR fixes that, adds the planned GitHub Actions update maintenance, and adds detectable fuzz/property-test coverage for the main parsing helpers.Validation
npm run lintnpm run buildnpm run test:coveragenpm run pack:checknpx prettier --check .github/workflows/ci.yml .github/workflows/codeql.yml .github/workflows/scorecard.yml .github/dependabot.yml CHANGELOG.md test/scorecard-property.test.ts package.json package-lock.jsonNotes
masterwere created directly on GitHub and classic branch protection was removed, so Scorecard can read branch policy without the previous token-visibility error.masterafter PR [codex] Harden Scorecard workflow integration #45 reached a computed score of7.0, but publication failed because of the annotated-tag pin forossf/scorecard-action. This PR fixes that publication issue.npm run validatein this checkout is still affected by the unrelated untracked.tasks/README.mdformatting issue in the working tree, so the validation here used the repo’s individual gates instead.