Skip to content

added reference for RFC9911, close #146 - #148

Open
mcr wants to merge 7 commits into
ad-view-commentsfrom
ketan-ad-comments
Open

added reference for RFC9911, close #146#148
mcr wants to merge 7 commits into
ad-view-commentsfrom
ketan-ad-comments

Conversation

@mcr

@mcr mcr commented Aug 5, 2026

Copy link
Copy Markdown
Member

this PR addresses DISCUSS and COMMENS from Ketan.

@mcr
mcr requested a review from EskoDijk August 5, 2026 13:32
>
> Provisional registration? (standards tree only):
> : NO
IANA is requested to update the registration of media type: `application/voucher-cms+json` to change the Published Specification to THIS-DOCUMENT.

@EskoDijk EskoDijk Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using multiple labels for the same currently:
[This RFC]
THIS DOCUMENT
THIS-DOCUMENT
this document

It's probably easiest for reviewers/editors if only one label is used?

RFC-editor, please remove.
This section just lists references present in YANG modules which otherwise do not get included in the references, like {{!RFC7250}}.

Also {{!RFC9911}}, Common YANG Data Types, and {{RFC8791}} is SX:Structure.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC 8791 is already referenced a couple of times from main text - to avoid confusion, I suggest to not include it here. The purpose was just to ensure the refs are there and this one was.

Suggested change
Also {{!RFC9911}}, Common YANG Data Types, and {{RFC8791}} is SX:Structure.
Also {{!RFC9911}}, Common YANG Data Types.

Comment thread ietf-voucher-request.yang
"Updates and additions described by RFC XXXX";
reference
"RFC XXXX: A Voucher Artifact for Bootstrapping Protocols";
"RFC XXXX: A Voucher Request Artifact for Bootstrapping Protocols";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Request" is not in the title of our new RFC - is this an accidental replace?

@EskoDijk EskoDijk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some suggestions/comments and the rest looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants