Second WGLC review by Esko - fixing various editorial issues and making readability improvements - #90
Merged
Merged
Conversation
EskoDijk
requested review from
QiufangMa,
mcr,
pritikin and
toerless
as code owners
November 26, 2025 15:17
EskoDijk
force-pushed
the
pr-wglc-review-2
branch
from
November 26, 2025 15:25
3cb35c8 to
31ca398
Compare
Member
|
Oh. I thought we wanted Capitalization for Terminology defined terms. |
Collaborator
Author
I use that in the Terminology section, to have readers know that the Capitalized Term is defined in the same list they're reading. For all other places outside of that list, it would lead to a lot of caps text - this is a common concern. On other drafts we therefore usually choose to not use caps then. (E.g. in snac-simple we only use it for specific message names like Router Advertisement etc.) So if this needs to be changed, that's possible also but mind that it will be a lot of caps. |
… minor editorial fixes/clarifications.
Collaborator
Author
|
In the second commit, Capitalization is now applied to all terms in the list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds two example vouchers: one with an extension, and a CBOR serialization of that.