exec: write output notebook incrementally after each cell#14
Merged
Conversation
Instead of collecting all results in memory and writing the output notebook once at the end, flush results to disk after each cell completes. This ensures partial results survive if the process is killed mid-execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The output notebook (
_out.ipynb) was only written once after all cells finished executing. If the process was killed mid-run (SIGKILL, OOM, machine crash), all collected results were lost.Solution
Flush the output notebook to disk after each cell completes instead of batching writes at the end. The output base notebook is now loaded before the cell loop, and a callback writes results incrementally as they arrive.
Context
The session notebook already used incremental writes via
NotebookWriter.flush(). This brings the--fileexecution path to parity — partial results now survive process crashes, not just Ctrl+C and cell errors.