test: add unit and integration tests for search service#5024
Merged
Conversation
abdnh
reviewed
Jun 17, 2026
|
|
||
| #[test] | ||
| fn build_search_string_converts_tag_node_to_anki_syntax() { | ||
| let (mut col, _tempdir) = open_fs_test_collection("search_service"); |
Contributor
There was a problem hiding this comment.
No need for open_fs_test_collection() in any of the tests? You can use Collection::new().
Contributor
Author
There was a problem hiding this comment.
thanks for catching this!
abdnh
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #4926
Summary / motivation
rslib/src/search/service/had no test coverage. This PR adds tests across two files (mod.rsandsearch_node.rs), covering:TryFrom<SearchNode>proto → domain conversions for all filter variantsFrom<Rating>andFrom<CardState>conversionsSearchServiceRPC methods:build_search_string,search_cards,browser_row_for_id,replace_search_nodeSortModeconstruction from proto, including theCustomfallbackbuild_search_stringwith an empty group returnsInvalidInputsearch_cardsHow to test