Skip to content

Update limit from 250 to 300MB.#46

Closed
GithubAnon0000 wants to merge 2 commits into
ankitects:mainfrom
GithubAnon0000:patch-1
Closed

Update limit from 250 to 300MB.#46
GithubAnon0000 wants to merge 2 commits into
ankitects:mainfrom
GithubAnon0000:patch-1

Conversation

@GithubAnon0000

@GithubAnon0000 GithubAnon0000 commented May 15, 2025

Copy link
Copy Markdown
Contributor

Also see: ankitects/anki#3981 (comment)

This info isn't in the manual as far as I can tell. Should it be added (also see #39)?

PS: No idea why line 11 shows a change. I didn't change anything there and the string looks identical to me.

Also see: ankitects/anki#3981 (comment)

This info isn't in the manual as far as I can tell. Should it be added?
@brishtibheja

brishtibheja commented May 15, 2025

Copy link
Copy Markdown
Contributor

you probably made a change and revert it in L11

can you not take this as an opportunity to include this info in the main manual and delete this portion of the FAQs? redirect people to the manual link.

@GithubAnon0000

Copy link
Copy Markdown
Contributor Author

you probably made a change and revert it in L11

I only edited the 250 in the webversion of github though. Github also should not show the unmodified string, if "all commits" are selected and the change would've been reverted. That's the weird part.

can you not take this as an opportunity to include this info in the main manual and delete this portion of the FAQs? redirect people to the manual link.

Sure.

@GithubAnon0000

Copy link
Copy Markdown
Contributor Author

So would I add a separate FAQ in the manual per topic and then link to them from the FAQ section? Dae hasn't clarified that yet (see ankitects/anki-manual#367) and I don't want to do the work twice.

@brishtibheja

Copy link
Copy Markdown
Contributor

This can easily fit somewhere in syncing.md and whatever fits in existing sections don't need their seperate FAQ. I think it's a point of consensus we have.

@GithubAnon0000

Copy link
Copy Markdown
Contributor Author

This can easily fit somewhere in syncing.md and whatever fits in existing sections don't need their seperate FAQ.

Right, so basically if I add it as a (sub)header, then it can be linked to and makes the FAQ entry obsolete. That's very reasonable.

Thanks!

@GithubAnon0000

Copy link
Copy Markdown
Contributor Author

I now removed the entry from the FAQ and refer to the manual. The link will only make sense, once ankitects/anki-manual#380 is merged in.

@GithubAnon0000 GithubAnon0000 marked this pull request as draft May 25, 2025 15:08
@GithubAnon0000

Copy link
Copy Markdown
Contributor Author

[Going through old PRs and closing them. I won't have enough time to update the PRs or develope them further for probably a few months. In case someone wants to continue here, feel free to so.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants