fix(sdk): narrow prompt part input id type#21312
Open
StatPan wants to merge 2 commits intoanomalyco:devfrom
Open
fix(sdk): narrow prompt part input id type#21312StatPan wants to merge 2 commits intoanomalyco:devfrom
StatPan wants to merge 2 commits intoanomalyco:devfrom
Conversation
The server rejects part IDs not starting with "prt" but the generated SDK types had id as plain string. Added PartIDInput template literal type and updated downstream call sites to match.
Author
|
A few things I considered: The generator (@hey-api/openapi-ts) doesn't translate OpenAPI The downstream changes in Open to feedback on the direction. |
Author
|
Related: #18205 — a plugin generating part IDs without the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21311
Type of change
What does this PR do?
The server rejects part IDs that don't start with
prt, but the generated SDK types hadid?: string. This adds aPartIDInput = \prt${string}`type and uses it forTextPartInput,FilePartInput,AgentPartInput, andSubtaskPartInput. A post-processing step in the build script keeps this correct when types are regenerated. Downstream call sites inpackages/appandpackages/opencode` were updated to match.How did you verify your code works?
Full turbo typecheck passes across all 13 packages. The
idfield type now matches the OpenAPI schema pattern^prt.*.Checklist