fix(opencode): use local time for log timestamps and filenames#21331
Open
elonnzhang wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): use local time for log timestamps and filenames#21331elonnzhang wants to merge 1 commit intoanomalyco:devfrom
elonnzhang wants to merge 1 commit intoanomalyco:devfrom
Conversation
Replace toISOString() (UTC) with Locale.localDatetime() (local time) in log entry formatting and log filename generation. Add Locale.localDatetime() utility to locale.ts. Fixes anomalyco#21330
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21330
Type of change
What does this PR do?
log.tsusedtoISOString()in two places, which outputs UTC time. For users outside UTC, log filenames and log entry timestamps don't match their local time, making it hard to correlate logs with what they were doing.This PR adds
Locale.localDatetime()tolocale.tsthat formats local time asYYYY-MM-DDTHH:mm:ssusing local time methods, then replaces bothtoISOString()calls inlog.tswith it.How did you verify your code works?
Ran opencode locally (UTC+8), confirmed log filename and timestamps inside the file now show local time instead of UTC.
Screenshots / recordings
N/A — not a UI change.
Checklist