fix(tui): prevent scroll snap when reading history during LLM response#21343
Open
divitkashyap wants to merge 2 commits intoanomalyco:devfrom
Open
fix(tui): prevent scroll snap when reading history during LLM response#21343divitkashyap wants to merge 2 commits intoanomalyco:devfrom
divitkashyap wants to merge 2 commits intoanomalyco:devfrom
Conversation
When a user scrolls up to read chat history while an LLM is still streaming, the view would snap back to the bottom on every token update due to stickyScroll=true always forcing scroll-to-bottom. This change tracks user scroll state via a userScrolledUp signal and makes stickyScroll reactive - only auto-scrolling when the user is at the bottom. User scroll commands (page up, line up, first message) set the flag to pause auto-scroll, while toBottom() and last message reset it to resume. Fixes anomalyco#4196
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Type of change
What does this PR do?
When a user scrolls up to read chat history while an LLM is still streaming, the view snaps back to the bottom on every token update. This is because
stickyScroll={true}on the message scrollbox forces scroll-to-bottom regardless of user scroll state.The fix adds a
userScrolledUpsignal that tracks when the user has manually scrolled away from the bottom. ThestickyScrollprop is now reactive (!userScrolledUp()), so auto-scroll only engages when the user is at the bottom.Upward scroll commands (Page Up, Line Up, Half Page Up, First Message) set the flag. Commands that return to bottom (toBottom(), Last Message) and session sync reset it.
How did you verify your code works?
bun run typecheckpasses in all 13 packagespackages/ui/src/hooks/create-auto-scroll.tsxfrom the web app, which implements the same behavior for the web clientChecklist