feat(tui): allow fork from AI messages#21349
Open
divitkashyap wants to merge 2 commits intoanomalyco:devfrom
Open
feat(tui): allow fork from AI messages#21349divitkashyap wants to merge 2 commits intoanomalyco:devfrom
divitkashyap wants to merge 2 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
divitkashyap
force-pushed
the
feat/fork-from-ai-message
branch
from
22b471b to
b576d41
Compare
The message.role type only allows 'user' or 'assistant', so checking for 'system' role was redundant. Removed the conditional to show all non-system messages in fork dialog.
divitkashyap
force-pushed
the
feat/fork-from-ai-message
branch
from
b576d41 to
1681daf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #8689
Type of change
What does this PR do?
The TUI fork dialog previously only allowed forking from user messages due to a role filter (). This change removes that filter entirely, allowing users to fork from both user and assistant messages.
Note: The message.role type only allows 'user' or 'assistant', so any role check against 'system' was redundant.
How did you verify your code works?
Code compiles successfully. The change removes a redundant conditional that was preventing assistant messages from appearing in the fork dialog.
Checklist