fix(opencode): align batch tool execution with active turn filtering#21366
Open
GuestAUser wants to merge 3 commits intoanomalyco:devfrom
Open
fix(opencode): align batch tool execution with active turn filtering#21366GuestAUser wants to merge 3 commits intoanomalyco:devfrom
GuestAUser wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21367
Type of change
What does this PR do?
batchwas resolving tools independently from the turn tool set, so it could miss model-gated tools likeapply_patchand drift from the tools actually exposed to the model.This change:
LLM.filterTools()as the shared turn filterSessionPromptviaextra.allowToolRegistry.tools(...)inbatchwith the active{ providerID, modelID }This keeps external / MCP tools out of
batchand makes batched execution match normal tool execution.How did you verify your code works?
cd packages/opencodebun test test/tool/batch.test.ts test/tool/apply_patch.test.tsbun typecheckbatch -> apply_patchunder a GPT-5-style patch turnapply_patchwhen the turn allowlist excludes itScreenshots / recordings
N/A — non-UI change.
Checklist