Skip to content

fix(vmware_guest_network): fix idempotency and diff issue due to the … #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanb74 wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −0
Open

fix(vmware_guest_network): fix idempotency and diff issue due to the … #2547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2132aa2
fix(vmware_guest_network): fix idempotency and diff issue due to the …
ryanb74 Mar 4, 2026
38250e5
add changelog fragment
ryanb74 Mar 4, 2026
6f38f9f
doc(vmware_guest_network): enhance mac_address argument documentation…
ryanb74 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/2547-vmware_guest_network_check_mode_vlan_id.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- vmware_guest_network - populate ``vlan_id`` in gathered NIC data for Distributed Virtual Portgroup backings so check mode diff does not report a false change when the NIC is already on the requested network.
3 changes: 3 additions & 0 deletions plugins/modules/vmware_guest_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@
mac_address:
description:
- MAC address of the NIC that should be altered, if a MAC address is not supplied a new nic will be created.
- Matching is case-sensitive; use the same MAC address case as reported by VMware to target an existing NIC.
- If the case does not match, the module can treat the adapter as missing and attempt to create a new NIC.
- Required when O(state=absent).
type: str
label:
Expand Down Expand Up @@ -412,6 +414,7 @@ def _get_nics_from_vm(self, vm_obj):
if hasattr(portgroup, 'key') and portgroup.key == key:
d_item['network_name'] = portgroup.name
d_item['switch'] = portgroup.config.distributedVirtualSwitch.name
d_item['vlan_id'] = self._get_vlanid_from_network(portgroup)
break
# If an NSX-T port group specified
elif isinstance(nic.backing, vim.vm.device.VirtualEthernetCard.OpaqueNetworkBackingInfo):
Expand Down