Fix failing windows modules with community.vmware.vmware_tools module on ansible-core 2.21.1

[chschenk]

SUMMARY

Currently the community.vmware.vmware_tools connection plugin does not work on windows targets with ansible-core 2.21.1. The underlying issues are the same as described here: ansible-collections/community.general#12161

1. The stdout and stderr return values of the exec_command function should be of type bytes and not str.
2. The values in -EncodedCommand and -EncodedArguments must not be quoted otherwise powershell refuses to parse these parameters.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

community.vmware.vmware_tools

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/ansible/buildset/b55cc1c5dcbc460f86932c19f3a33661

✔️ ansible-tox-linters SUCCESS in 5m 07s
✔️ ansible-galaxy-importer SUCCESS in 6m 38s (non-voting)
✔️ build-ansible-collection SUCCESS in 6m 42s

[mariolenz]

Sorry, I thought I've already answered. Either I've started and didn't sent the comment, or I did and something went wrong.

1. I don't use this functionality in our environment, so I don't know how to test this. And we still don't have a solution to run integration tests (again) for this collection. So I guess I just have to trust you that this really fixes things.
2. Please add a changelog fragment.

Maybe something like changelogs/fragments/2554-fix-vmware_tools.yml:

bugfixes:
  - vmware_tools - Fix an issue with ansible-core 2.21 (https://github.com/ansible-collections/community.vmware/pull/2554).

You might have to create the changelogs/fragments directory first, though.

Out of curiosity, do you run into the same issue with ansible-core 2.21.0? I would be really surprised if the module works there and just started to fail with 2.21.1.