Allow skipping PostgreSQL database backup/restore#2120
Open
dsavineau wants to merge 1 commit into
Open
Conversation
dsavineau
force-pushed
the
skip_db_backup_restore
branch
from
649f081 to
e8e658c
Compare
dsavineau
requested review from
jamesmarshall24,
lucas-benedito and
rooftopcellist
This allows one to skip the PostgreSQL database dump/restore during via the AWXBackup and AWXRestore CRDs on external database configuration. A new parameter called `postgres_skip_data` is introduced (defaults to false for backward compatibility) but can be turn on to skip the pg_dump and pg_restore parts. That value is passed down to nested components so other pg_dump/pg_restore calls are also skipped. At restore time, if no database dump file is found in the backup then the `postgres_skip_data` parameter needs to be explicitely set to true. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
dsavineau
force-pushed
the
skip_db_backup_restore
branch
from
e8e658c to
2a6e714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This allows one to skip the PostgreSQL database dump/restore during via the AWXBackup and AWXRestore CRDs on external database configuration.
ISSUE TYPE
ADDITIONAL INFORMATION
A new parameter called
postgres_skip_datais introduced (defaults to false for backward compatibility) but can be turn on to skip the pg_dump and pg_restore parts.At restore time, if no database dump file is found in the backup then the
postgres_skip_dataparameter needs to be explicitely set to true.