Phase 2b: desktop sidecar (build but do not publish)#11
Merged
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 30214789 | Triggered | Username Password | 11e6902 | gems/mysql_genius-desktop/spec/mysql_genius/desktop/config/mysql_config_spec.rb | View secret |
| 30214789 | Triggered | Username Password | 634895e | gems/mysql_genius-desktop/spec/mysql_genius/desktop/config_spec.rb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gems/mysql_genius-desktop(version 0.1.0): a Sinatra + Trilogy sidecar that serves the shared MysqlGenius dashboard against any MySQL/MariaDB server configured via local YAML. First non-Rails consumer ofmysql_genius-core 0.6.0.Core::Connection::TrilogyAdapter(reopensCore::Connectionnamespace from the desktop gem, same pattern asActiveRecordAdapterin the Rails gem).capability?(name)helper toSharedViewHelpers+ template guards around the three Redis-backed features (slow_queries,anomaly_detection,root_cause). Rails adapter always reports:slow_queriesas a capability, so nothing visible changes for Rails host apps.mysql_genius-desktopstays in-repo at 0.1.0..github/workflows/publish.ymlis untouched. Bothmysql_geniusandmysql_genius-corestay at 0.6.0 — no version bump, no tag, no publish fire.Test plan
mysql_genius-coresuite green (194 examples unchanged)mysql_genius-corerubocop clean (60 files)mysql_genius-desktopsuite green (111 examples: 13 TrilogyAdapter, 22 Config sub-struct, 12 Config loader, 10 ActiveSession, 9 Launcher, 5 index, 3 columns, 5 execute, 3 explain, 7 analysis, 12 AI features, 3 redis 404, 7 capabilities)mysql_genius-desktoprubocop clean (36 files)desktopCI job runs green on the PRTESTING.mdrecipe against local MySQL 8.0 in Docker — every tab renders, Slow Queries / Root Cause / Anomaly UI confirmed hidden, unregistered routes 404See
docs/superpowers/specs/2026-04-12-phase-2b-desktop-sidecar-design.mdfor the full design.