fix: read actual package version for srt --version output#217
Open
javabrett wants to merge 1 commit into
Open
Conversation
process.env.npm_package_version is only set when running via npm scripts (npm run, npx), not when executing the compiled binary directly. This caused `srt --version` to always return the hardcoded fallback "1.0.0" regardless of the installed package version. Fix reads the version from package.json at runtime via import.meta.url, which correctly resolves relative to dist/cli.js in the installed package. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
srt --versionalways returns1.0.0regardless of the installed package version.The current code relies on
process.env.npm_package_version:npm_package_versionis only populated by npm when running package scripts vianpm runornpx. It is not set when executing the compiled binary directly(e.g.
srt --version,srt -c "..."), which is how srt is used in practice.The hardcoded
'1.0.0'fallback is therefore always reached.Fix
Read the version from
package.jsonat runtime, relative to the compileddist/cli.jsviaimport.meta.url:package.jsonis always present in an installed npm package, so this isreliable in all execution contexts. The
npm_package_versionenv var is notkept as a fallback - when it IS set (npm scripts, npx), the package.json read
returns the same value anyway, making the fallback chain redundant.
Testing
npm run build node dist/cli.js --version # now returns the actual version, not 1.0.0