fix: join multiple beta headers with commas per API specfix: join multiple beta headers with commas per API spec#287
Open
aydinomer00 wants to merge 1 commit intoanthropics:mainfrom
Conversation
Fixes anthropics#266. When multiple beta features are requested, Go's Header.Add() creates separate HTTP header lines (Anthropic-Beta: value1, then Anthropic-Beta: value2). The Anthropic API docs specify that multiple beta features should be comma-separated in a single header (Anthropic-Beta: value1,value2). Replaced the for-loop + individual WithHeaderAdd pattern with strings.Join to produce a single comma-separated header value across all beta service files (8 files, 17 occurrences). Added a middleware-based unit test to verify comma-separated format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266. When multiple beta features are requested, Go's Header.Add() creates separate HTTP header lines (Anthropic-Beta: value1, then Anthropic-Beta: value2). The Anthropic API docs specify that multiple beta features should be comma-separated in a single header (Anthropic-Beta: value1,value2).
Replaced the for-loop + individual WithHeaderAdd pattern with strings.Join to produce a single comma-separated header value across all beta service files (8 files, 17 occurrences).
Added a middleware-based unit test to verify comma-separated format.