fix: correct Windows OS detection typo in getNormalizedOS#289
Open
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Open
fix: correct Windows OS detection typo in getNormalizedOS#289MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Conversation
`runtime.GOOS` returns "windows" on Windows, but `getNormalizedOS()` checks for "window" (missing trailing 's'). This causes the function to fall through to the default case, reporting "Other:windows" instead of "Windows" in the X-Stainless-OS header for all Windows users. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNormalizedOS()ininternal/requestconfig/requestconfig.gocompares against"window"instead of"windows", causing Windows users to always hit the default case and report"Other:windows"in theX-Stainless-OSheader instead of"Windows"runtime.GOOSreturns"windows"(with trailing 's') on Windows — see Go documentation"window"->"windows"Test plan
runtime.GOOSdocumentation confirms the value is"windows"not"window"X-Stainless-OSheader now reports"Windows"instead of"Other:windows"🤖 Generated with Claude Code