fix: join text blocks with empty string in finalText#950
Open
frankgoldfish wants to merge 1 commit intoanthropics:mainfrom
Open
fix: join text blocks with empty string in finalText#950frankgoldfish wants to merge 1 commit intoanthropics:mainfrom
frankgoldfish wants to merge 1 commit intoanthropics:mainfrom
Conversation
textBlocks.join(' ') was inserting an unexpected space character between
multiple text content blocks. This is inconsistent with the Python SDK which
uses ''.join(text_blocks). When the API returns multiple text blocks they
should be concatenated without any separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#getFinalText()insrc/lib/MessageStream.tsto join multiple text blocks with an empty string instead of a spaceBug
#getFinalText()was callingtextBlocks.join(' '), which inserts an unexpected space character between text content blocks:When a response contains two adjacent text blocks (
"Hello"and" world"), the result would be"Hello world"(double space) instead of"Hello world".Fix
This matches the Python SDK which uses
"".join(text_blocks)(empty separator), and the docstring which says the blocks are concatenated (not space-joined).Test plan
"".join(text_blocks))🤖 Generated with Claude Code