Skip to content

descriptor: reject duplicate oneof names - #415

Open
fallintoplace wants to merge 1 commit into
anthropics:mainfrom
fallintoplace:fix/reject-duplicate-oneof-names
Open

descriptor: reject duplicate oneof names#415
fallintoplace wants to merge 1 commit into
anthropics:mainfrom
fallintoplace:fix/reject-duplicate-oneof-names

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

What changed

  • Reject duplicate oneof names within a message in DescriptorPool.
  • Add a precise PoolError variant and display message.
  • Add hand-built descriptor tests for rejection, transactional behavior, and distinct names.

Checks

  • cargo test -p buffa-descriptor --features reflect --test pool_e2e
  • cargo test -p buffa-descriptor --all-features
  • cargo clippy -p buffa-descriptor --all-targets --all-features -- -D warnings
  • cargo fmt --all -- --check

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant