descriptor: reject duplicate reserved names - #419
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
force-pushed
the
fix/reject-duplicate-reserved-names
branch
from
September 3, 2026 11:36
9c31e6e to
737e752
Compare
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DescriptorPool now rejects duplicate reserved names.
reserved_nameentries on messagesreserved_nameentries on enumsWhy
A hand-built descriptor set could repeat a reserved name and the pool would silently deduplicate it.
Tests
cargo test -p buffa-descriptor --features reflect --test pool_e2ecargo test -p buffa-descriptor --all-featurescargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --check