Skip to content

descriptor: reject duplicate reserved names - #419

Open
fallintoplace wants to merge 1 commit into
anthropics:mainfrom
fallintoplace:fix/reject-duplicate-reserved-names
Open

descriptor: reject duplicate reserved names#419
fallintoplace wants to merge 1 commit into
anthropics:mainfrom
fallintoplace:fix/reject-duplicate-reserved-names

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What changed

DescriptorPool now rejects duplicate reserved names.

  • Checks duplicate reserved_name entries on messages
  • Checks duplicate reserved_name entries on enums
  • Keeps the same reserved name valid in different owners
  • Failed additions stay transactional

Why

A hand-built descriptor set could repeat a reserved name and the pool would silently deduplicate it.

Tests

  • cargo test -p buffa-descriptor --features reflect --test pool_e2e
  • cargo test -p buffa-descriptor --all-features
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo fmt --all -- --check

@fallintoplace
fallintoplace force-pushed the fix/reject-duplicate-reserved-names branch from 9c31e6e to 737e752 Compare September 3, 2026 11:36
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant