fix: correct hooks.json shape from [] to {"hooks":{}} in four plugins#124
Closed
Hammad64-bits wants to merge 1 commit into
Closed
fix: correct hooks.json shape from [] to {"hooks":{}} in four plugins#124Hammad64-bits wants to merge 1 commit into
Hammad64-bits wants to merge 1 commit into
Conversation
Fixes anthropics#123 The plugin loader expects an object with a record key, not an array. Four vertical plugins were scaffolded with an empty [] placeholder instead of the correct {"hooks":{}} shape, causing 'Hook load failed' on install. Affected plugins: - financial-analysis - equity-research - private-equity - wealth-management investment-banking already had the correct shape and is unchanged.
Collaborator
|
Thanks for catching this and taking the time to send a fix! 🙏 This was reported by many contributors — the underlying bug is now resolved in #232, which repairs all four broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
The plugin loader expects an object with a record key, not an array. Four vertical plugins were scaffolded with an empty [] placeholder instead of the correct {"hooks":{}} shape, causing 'Hook load failed' on install.
Affected plugins:
investment-banking already had the correct shape and is unchanged.