feat(skill-creator): add --eval-model option for separate eval and improvement models#851
Open
heshaofu2 wants to merge 1 commit intoanthropics:mainfrom
Open
Conversation
Allow using a separate model for eval trigger testing while keeping --model as the primary model for description improvement. This enables cost-effective workflows where a lighter model handles the high-volume parallel eval phase and a stronger model handles the single-call description rewrite phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
--eval-modelCLI argument torun_loop.py, allowing users to specify a different model for the eval trigger-testing phase while--modelremains the primary model for description improvement.Motivation
The
run_loop.pyscript has two distinct phases with very different cost/quality profiles:Currently both phases are forced to use the same
--model. In practice, users often want a lighter/cheaper model for the high-volume eval phase and a stronger model for the single-call description improvement. For example:Changes
4 minimal changes in
skills/skill-creator/scripts/run_loop.py:run_loop()function: Addedeval_model: str | None = Noneparameterrun_eval()call: Changedmodel=model→model=eval_model or model(falls back to--modelwhen not set)improve_description()call: Unchanged — always uses--model(the primary model)--eval-modelargument; updated--modelhelp text from "Model for improvement" to "Model for all stages (improvement and eval)"Backward Compatibility
Fully backward compatible. Without
--eval-model, behavior is identical to the current version — both phases use--model.Testing
Tested locally with:
Both modes produce correct results. The
--eval-modelvariant completes eval phases significantly faster while maintaining improvement quality.