roads and bridges fixes

[anton-makarevich]

Summary by CodeRabbit

• Bug Fixes

  • Water terrain now replaces existing ground terrain correctly.
  • Adding water over a road converts the road to a bridge while removing conflicting ground layers.
  • Clear terrain is now handled consistently when applying other ground terrain types.

• Tests

  • Added coverage for water, ground, road, and bridge terrain-layering behavior.

[coderabbitai]

Warning

Review limit reached

@anton-makarevich, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 83631150-37f6-4595-a0e5-609532203898

📥 Commits

Reviewing files that changed from the base of the PR and between ff519b9 and 60a0f7f.

📒 Files selected for processing (1)

• Directory.Build.props

📝 Walkthrough

Walkthrough

Water terrain application now removes existing ground terrain, including Clear, while preserving road layering behavior and converting roads to bridges when appropriate. Tests cover Water interactions with ground and road terrain, plus non-water replacement of Clear.

Changes

Terrain layering behavior

Layer / File(s)	Summary
Update terrain layering rules src/MakaMek.MapEditor/ViewModels/EditMapViewModel.cs	Clear is recognized as ground terrain, and applying Water removes existing ground terrain before road and bridge handling.
Validate terrain combinations tests/MakaMek.MapEditor.Test/ViewModels/EditMapViewModelTests.cs	Tests cover Water replacing Clear, woods, and rough terrain; Water with road converts the road to a bridge; woods and rough terrain replace Clear.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• anton-makarevich/MakaMek.MapEditor#19: Refactors hex-selection routing in EditMapViewModel, which this change extends with terrain-layering behavior.
• anton-makarevich/MakaMek.MapEditor#82: Also modifies terrain layering for Water, ground, roads, and bridges with related tests.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches a real part of the change set by calling out road-to-bridge behavior and related terrain fixes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/47-roads-and-bridges

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}