Skip to content

Fix data race in Linux compress maintainer tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoninbas merged 1 commit into from
Jun 3, 2026
+8 −7
Merged

Fix data race in Linux compress maintainer tests #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"os"
"syscall"
"testing"
"time"
)

func TestMaintainMode(t *testing.T) {
Expand Down Expand Up @@ -115,9 +114,10 @@ func TestCompressMaintainMode(t *testing.T) {
err = l.Rotate()
isNil(err, t)

// we need to wait a little bit since the files get compressed on a different
// goroutine.
<-time.After(10 * time.Millisecond)
// Closing flushes the pending compression and waits for the mill
// goroutine to exit, which also synchronizes its writes with the
// assertions below.
isNil(l.Close(), t)

// a compressed version of the log file should now exist with the correct
// mode.
Expand Down Expand Up @@ -165,9 +165,10 @@ func TestCompressMaintainOwner(t *testing.T) {
err = l.Rotate()
isNil(err, t)

// we need to wait a little bit since the files get compressed on a different
// goroutine.
<-time.After(10 * time.Millisecond)
// Closing flushes the pending compression and waits for the mill
// goroutine to exit, which also synchronizes its writes to fakeFS with
// the assertions below.
isNil(l.Close(), t)

// a compressed version of the log file should now exist with the correct
// owner.
Expand Down
Loading