Skip to content

fix(tmap): add resize event listener to handle browser window resize (fixes #2751) #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzxue merged 3 commits into from
Mar 18, 2026
Merged

fix(tmap): add resize event listener to handle browser window resize (fixes #2751) #2833

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
422b3a9
fix(tmap): add resize event listener to handle browser window resize …
lzxue Mar 18, 2026
f578cb1
fix(tmap): fix lint - add space before comment
lzxue Mar 18, 2026
15059f5
fix(tmap): add resize event listener (fixes #2751)
lzxue Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/maps/src/tmap/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ export default class TMapService extends BaseMapService<TMap.Map> {
this.map.on('rotate', this.handleCameraChanged);
this.map.on('pitch', this.handleCameraChanged);
this.map.on('zoom', this.handleCameraChanged);
this.map.on('resize', this.handleCameraChanged);// FIX #2751: handle window resize

@gemini-code-assist gemini-code-assist Bot Mar 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This inline comment is redundant, as the code is self-explanatory and the rationale for the change is well-documented in the commit message and pull request. Removing it will improve code consistency with the other event listener registrations in this block.

Suggested change
this.map.on('resize', this.handleCameraChanged);// FIX #2751: handle window resize
this.map.on('resize', this.handleCameraChanged);
References
  1. Code should be self-documenting. Avoid comments that just repeat what the code does. The 'why' behind a change, especially for a bug fix, is best captured in commit messages and pull request descriptions, not as inline comments.


// Trigger camera change after init
this.handleCameraChanged();
Expand Down Expand Up @@ -464,3 +465,4 @@ export default class TMapService extends BaseMapService<TMap.Map> {
DOM.addClass(container, 'tmap-contianer--hide-logo');
}
}

Loading