Skip to content

refactor(maps): DRY creatMapContainer 解析逻辑，复用 super 调用 #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzxue merged 1 commit into from
Jul 21, 2026
Merged

refactor(maps): DRY creatMapContainer 解析逻辑，复用 super 调用 #2880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/maps/src/map/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,7 @@ export default class DefaultMapService extends MapboxBaseMap<Map> {
}

protected creatMapContainer(id: string | HTMLDivElement) {
let wrapper = id as HTMLDivElement;
if (typeof id === 'string') {
wrapper = document.getElementById(id) as HTMLDivElement;
}
const wrapper = super.creatMapContainer(id);
const container = document.createElement('div');
Comment thread
lzxue marked this conversation as resolved.
container.style.cssText += `
position: absolute;
Expand Down
5 changes: 1 addition & 4 deletions packages/maps/src/mapbox/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,7 @@ export default class MapboxService extends MapboxBaseMap<Map & IMapboxInstance>
}

protected creatMapContainer(id: string | HTMLDivElement) {
let $wrapper = id as HTMLDivElement;
if (typeof id === 'string') {
$wrapper = document.getElementById(id) as HTMLDivElement;
}
const $wrapper = super.creatMapContainer(id);
const $amapdiv = document.createElement('div');
Comment thread
lzxue marked this conversation as resolved.
$amapdiv.style.cssText += `
position: absolute;
Expand Down
5 changes: 1 addition & 4 deletions packages/maps/src/maplibre/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,7 @@ export default class Service extends MapboxBaseMap<Map & IMapboxInstance> {
}

protected creatMapContainer(id: string | HTMLDivElement) {
let $wrapper = id as HTMLDivElement;
if (typeof id === 'string') {
$wrapper = document.getElementById(id) as HTMLDivElement;
}
const $wrapper = super.creatMapContainer(id);
const $amapdiv = document.createElement('div');
Comment thread
lzxue marked this conversation as resolved.
$amapdiv.style.cssText += `
position: absolute;
Expand Down
5 changes: 1 addition & 4 deletions packages/maps/src/tdtmap/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,10 +527,7 @@ export default class TdtMapService extends BaseMap<any> {
}

protected creatMapContainer(id: string | HTMLDivElement) {
let $wrapper = id as HTMLDivElement;
if (typeof id === 'string') {
$wrapper = document.getElementById(id) as HTMLDivElement;
}
const $wrapper = super.creatMapContainer(id);
const $tdtmapdiv = document.createElement('div');
Comment thread
lzxue marked this conversation as resolved.
$tdtmapdiv.style.cssText += `
position: absolute;
Expand Down
Loading