[WIp] ALP encoder/decoder support#9372
Open
sdf-jkl wants to merge 44 commits into
Open
Conversation
Contributor
|
amaaazing |
Contributor
Author
|
@alamb I worked with codex on replicating the c++ implementation reviewing commit by commit. I'll do one final read myself, but this should be ready for initial review. |
Contributor
|
Thank you -- I will put this on my short list to reivew I was out last week |
devanbenz
suggested changes
Feb 27, 2026
devanbenz
reviewed
Feb 27, 2026
Contributor
Author
|
@devanbenz Sorry for taking so long to address your comments. I'll make sure to work on it this week! |
Contributor
devanbenz
suggested changes
Mar 11, 2026
devanbenz
left a comment
devanbenz
left a comment
There was a problem hiding this comment.
Comment about header regarding publication of spec.
Contributor
Author
|
Thanks @devanbenz, I've finally addressed your reviews! |
Please cargo fmt the code 🫡 |
Contributor
Author
|
|
This was referenced May 8, 2026
Refactor: Pull common header structures into common module
Contributor
|
here is another small proposed improvement |
Align structure names with spec
alamb
added a commit
that referenced
this pull request
May 14, 2026
# Which issue does this PR close? - Related to #9372 # Rationale for this change Similarly to #9948. I ran into BitWriter as part of reviewing code from @sdf-jkl and wanted to document my findings (so I didn't have to re-read the code each time) - #9372 # What changes are included in this PR? Add docs # Are these changes tested? By CI # Are there any user-facing changes? No -- this is docs to an internal structure
alamb
added a commit
that referenced
this pull request
May 14, 2026
# Which issue does this PR close? - Related to #9372 # Rationale for this change While reviewing the ALP implementation from @sdf-jkl , I ran into this struct which I haven't really used before. - #9372 Now that I have read it, I wanted to capture that information as doc comments (for my future self and hopefully for others) # What changes are included in this PR? Add documentation comments to `BitReader` # Are these changes tested? Just docs, # Are there any user-facing changes? Just docs on an internal struct,
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? - Related to apache#9372 # Rationale for this change Similarly to apache#9948. I ran into BitWriter as part of reviewing code from @sdf-jkl and wanted to document my findings (so I didn't have to re-read the code each time) - apache#9372 # What changes are included in this PR? Add docs # Are these changes tested? By CI # Are there any user-facing changes? No -- this is docs to an internal structure
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? - Related to apache#9372 # Rationale for this change While reviewing the ALP implementation from @sdf-jkl , I ran into this struct which I haven't really used before. - apache#9372 Now that I have read it, I wanted to capture that information as doc comments (for my future self and hopefully for others) # What changes are included in this PR? Add documentation comments to `BitReader` # Are these changes tested? Just docs, # Are there any user-facing changes? Just docs on an internal struct,
Contributor
Author
Contributor
|
Thanks @sdf-jkl -- I will try and find tiume to review this (probably not until the weekend though as I have to sort out the next object store release before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
check issue
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?