Skip to content

Migrate Common Linting Tooling to Rust-Based Packages#38107

Open
jrmccluskey wants to merge 6 commits intomasterfrom
ruffExperiment
Open

Migrate Common Linting Tooling to Rust-Based Packages#38107
jrmccluskey wants to merge 6 commits intomasterfrom
ruffExperiment

Conversation

@jrmccluskey
Copy link
Copy Markdown
Contributor

@jrmccluskey jrmccluskey commented Apr 8, 2026

Migrates from pylint, mypy, and isort to ruff and pyrefly for common linting and static type checking workflows. Also includes updates for pre-commit hooks and agentic skills. Also adds a "dev" extra class in setup.py to A) keep versions of these packages pinned in a singular place and B) allow developers to install these tools via pip easily.

Work based on https://s.apache.org/beam-python-rust-tooling


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Apr 8, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the project's Python code quality infrastructure by migrating from traditional Python-based linting and type-checking tools (pylint, mypy, flake8) to their modern, Rust-based counterparts (ruff, pyrefly). This transition aims to enhance performance and streamline development workflows, providing a more efficient and consistent code quality enforcement mechanism. The changes encompass updates to pre-commit configurations, build scripts, and development environment setup, including a new dev extra for easy installation of these tools.

Highlights

  • Linting Tool Migration: Migrated Python linting from pylint and flake8 to the Rust-based ruff.
  • Type Checking Tool Migration: Migrated Python type checking from mypy to pyrefly.
  • Pre-commit Hook Updates: Updated pre-commit configurations to replace the pylint hook with ruff-check.
  • Development Dependencies Management: Introduced a new dev extra in setup.py to centralize and pin versions of development tools like isort, pyrefly, ruff, and yapf.
  • Configuration and Script Updates: Updated agentic skills documentation, tox.ini configurations, and run_pylint.sh script to reflect the new linting and type checking tooling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jrmccluskey jrmccluskey changed the title [WIP] Migrate Common Linting Tooling to Rust-Based Packages Migrate Common Linting Tooling to Rust-Based Packages Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant