Skip to content

Add PreCommit Java Dataflow workflow (#38094)#38124

Open
liferoad wants to merge 4 commits intomasterfrom
fix/beam-38094-slow-streaming-test
Open

Add PreCommit Java Dataflow workflow (#38094)#38124
liferoad wants to merge 4 commits intomasterfrom
fix/beam-38094-slow-streaming-test

Conversation

@liferoad
Copy link
Copy Markdown
Contributor

@liferoad liferoad commented Apr 9, 2026

What

Split Dataflow worker tests into a standalone PreCommit workflow to reduce Java PreCommit runtime.

Why

Issue #38094: suite takes >1h, causing the main Java PreCommit to time out. All listed tests pass — they're just slow (~5 min each):

  • (×2 configs) — 5m+ each
  • , — 5m+ each
  • variants — 5m+ each
  • variants — 1m24s - 1m41s each

Changes

  • New workflow:
    • Runs only on changes to
    • Triggers: push, PR, schedule (every 6h), workflow_dispatch, issue comment
    • Runs (not full )
    • Timeout: 240 min
  • New trigger file:

Testing

  • YAML validated locally
  • Branch pushed to

Closes #38094

@liferoad
Add PreCommit Java Dataflow workflow (#38094)
935b8a4 
Split Dataflow worker tests into a separate PreCommit job to reduce
Java PreCommit runtime. The StreamingDataflowWorkerTest suite takes >1h,
causing the main Java PreCommit to exceed typical CI timeouts.

New workflow: beam_PreCommit_Java_Dataflow
- Runs only on changes to runners/google-cloud-dataflow-java/worker/**
- Triggers on push, PR, schedule (every 6h), workflow_dispatch, and
  issue comment 'Run Java Dataflow PreCommit'
- Runs :runners:google-cloud-dataflow-java:worker:test
- Timeout: 240 minutes

Fixes #38094
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Apr 9, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses long-running test suites in the Java PreCommit process by offloading Dataflow worker tests into a separate, standalone workflow. This change aims to prevent timeouts in the main pipeline by isolating these time-intensive tests, ensuring more efficient CI execution.

Highlights

  • New PreCommit Workflow: Introduced a dedicated PreCommit workflow for Dataflow worker tests to optimize the main Java PreCommit runtime.
  • Trigger Configuration: Added a new trigger file to manage the execution of the Dataflow worker test suite.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PreCommit_Java_Dataflow.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions bot added the build label Apr 9, 2026
liferoad added 3 commits April 8, 2026 20:29
@liferoad
Add release/trigger_all_tests.json to trigger path per GHA validation
a1a574d
@liferoad
Exclude Dataflow worker from main Java PreCommit (#38094)
66b3134 
Add !runners/google-cloud-dataflow-java/worker/** to both push and
pull_request_target path filters in beam_PreCommit_Java.yml.

Without this, the main Java PreCommit still runs the full javaPreCommit
(including slow StreamingDataflowWorkerTest) on worker changes, which
defeats the purpose of splitting to a separate PreCommit job.
@liferoad
Add beam_PreCommit_Java_Dataflow.yml to workflows/README.md
0671ed9
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Assigning reviewers:

R: @Abacn for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Next Action: Reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Failing Test]: long running StreamingDataflowWorkerTest

1 participant

@liferoad